3241 refactor get agent binary methods #3252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mssalvatore
force-pushed
the
3241-refactor-get-agent-binary-methods
branch
from
d9b46fd to
b865448
Compare
cakekoa
reviewed
Apr 25, 2023
...ts/unit_tests/monkey_island/cc/services/agent_binary_service/test_agent_binary_repository.py
Outdated
Show resolved
Hide resolved
These were replaced by IAgentBinaryRepository.get_agent_binary(OperatingSystem)
mssalvatore
force-pushed
the
3241-refactor-get-agent-binary-methods
branch
from
b865448 to
7d984c2
Compare
cakekoa
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Issue #3241
Change the interface of
IAgentBinaryServiceto provideget_agent_binary()PR Checklist
Was the CHANGELOG.md updated to reflect the changes?Was the documentation framework updated to reflect the changes?Testing Checklist